gregfr on "[Plugin: WooCommerce PDF Invoices] Double save smashes existing invoice"

Greetings
I have this weird behavior where invoices are correctly sent in the email, but when downloaded later are blank.

This bug didn't occur in the a previous version I was using.

I investiguated and found that BEWPI_Invoice->save() is called twice, which lead me to this:

/woocommerce-pdf-invoices/includes/be-woocommerce-pdf-invoices.php line 70:


/**
* Attach invoice to a specific WooCommerce email
*/
add_filter( 'woocommerce_email_attachments', array( &$this, 'attach_invoice_to_email' ), 99, 3 );

/**
* Attach invoice to a new order email
*/
add_filter( 'woocommerce_email_attachments', array( &$this, 'attach_invoice_to_new_order_email' ), 99, 3 );


To the same filter tag are attached to functions, which are very similar.

Why these two functions should be called by the same filter?

Thanks in advance

greg

https://wordpress.org/plugins/woocommerce-pdf-invoices/